Don't override user provided compile definitions

[emersonknapp]

Related to ros2/rosidl#743

set_target_properties does not append to values, it only sets them. target_compile_options on the other hand appends to any preexisting values.

Because of that, rosidl_typesupport_cpp C++ target was overriding user provided compiler options, which hid (for example) -Wdeprecated warnings in generated code in nav2_msgs.

[emersonknapp]

Pulls: ros2/rosidl#750, ros2/rosidl_typesupport#145, ros2/rosidl_typesupport_fastrtps#102 Gist: https://gist.githubusercontent.com/emersonknapp/c6789af2426c339278a67550f46ca634/raw/181d85f1ca93d4cbf3472e6379a59ffdbd47a395/ros2.repos BUILD args: TEST args: ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12163

• Linux
• Linux-aarch64
• Windows

[emersonknapp]

Rerunning aarch64

[emersonknapp]

@mergifyio backport iron humble

[mergify[bot]]

backport iron humble

❌ Command disallowed due to command restrictions in the Mergify configuration.

- [ ] `sender-permission>=write`

[quarkytale]

@Mergifyio backport iron humble

[mergify[bot]]

backport iron humble

✅ Backports have been created

* [#146 Don't override user provided compile definitions (backport #145)](https://github.com/ros2/rosidl_typesupport/pull/146) has been created for branch `iron` * [#147 Don't override user provided compile definitions (backport #145)](https://github.com/ros2/rosidl_typesupport/pull/147) has been created for branch `humble`