search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Don't override user provided compile definitions (backport #145) #147

Closed mergify[bot] closed 1 year ago

mergify[bot] commented 1 year ago

This is an automatic backport of pull request #145 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
emersonknapp commented 1 year ago

@quarkytale @sloretz friendly ping to commit suggestions at earliest convenience - then I'll kick off CI

emersonknapp commented 1 year ago

@clalancette @quarkytale @sloretz ping!

clalancette commented 1 year ago

@quarkytale @sloretz friendly ping to commit suggestions at earliest convenience - then I'll kick off CI

Done now, feel free to kick off CI.

emersonknapp commented 1 year ago

Pulls: ros2/rosidl_typesupport#147 Gist: https://gist.githubusercontent.com/emersonknapp/77b08500e1e2f79c2865a5dbe78c466e/raw/45fb4e69c916f4568d0ebb7c9e996a739e099c40/ros2.repos BUILD args: TEST args: ROS Distro: humble Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12298