search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Integrate CoreDX DDS (https://github.com/tocinc/rmw_coredx) #20

Closed ClarkTucker closed 6 years ago

ClarkTucker commented 6 years ago

rmw_coredx has been updated to https://github.com/ros2/ros2/tree/release-ardent-20180307

With these changes, rosidl_typesupport will include build support for rmw_coredx.

dirk-thomas commented 6 years ago

Thank you for creating this PR. We will have to be able to run CI across all supported platforms before we can accept the patch. I will reach out to you via email to determine the path forward on this.

mikaelarguedas commented 6 years ago

@dirk-thomas note that there is a coredx branch here and on rmw_implementation with these changes. They should be removed when this PR gets merged

dirk-thomas commented 6 years ago

With the merged PR #22 and the pending PR tocinc/rmw_coredx#19 this is not necessary anymore.

I also deleted the coredx branch in this repo.

mikaelarguedas commented 6 years ago

@dirk-thomas I see you kept the coredx branch the rmw_implementation repo. I would have expected that branch to not be necessary since https://github.com/tocinc/rmw_coredx/commit/e55b8f0ea089b7e20d651f392bdfd130fef5562a, isn't it ?

dirk-thomas commented 6 years ago

I missed that one - thanks for catching it - gone now too.