search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Add `rcpputils` for `find_library` #47

Closed EricCousineau-TRI closed 4 years ago

EricCousineau-TRI commented 5 years ago

Signed-off-by: Eric Cousineau eric.cousineau@tri.global

Compadre of ros2/rcpputils#4

Er... This is namely for crystal. How do I handle backporting from / forward porting to master?

This change is Reviewable

Connects to ros2/rcpputils#4

dirk-thomas commented 5 years ago

This is namely for crystal. How do I handle backporting from / forward porting to master?

Please target the default branch with any pull request (except if the change is only applicable to the target branch).

In this specific case since the change is only a cleanup there is no need to backport it for Crystal so it is unlikely that this is going to happen.

EricCousineau-TRI commented 5 years ago

In this specific case since the change is only a cleanup there is no need to backport it for Crystal so it is unlikely that this is going to happen.

I'm actually using this to lead into ros2/rcutils#143, hoping to get some mileage out of that in Crystal ;P But will target default branch for now - thanks!

EricCousineau-TRI commented 4 years ago

Working on this now; should I merge in updated branch, rebase, or close and open a new PR?

dirk-thomas commented 4 years ago

Rebased and resolved conflicts: