search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

added rosidl_runtime c depencency #58

Closed ahcorde closed 4 years ago

ahcorde commented 4 years ago

This PR is related to the changes introduced in this PR https://github.com/ros2/rosidl/pull/442. The full process can be followed here https://github.com/ros2/rosidl/issues/443

Signed-off-by: ahcorde ahcorde@gmail.com

dirk-thomas commented 4 years ago

I simple change of name from generator to runtime is easy to understand. But when you add / remove dependencies please describe why you do it.

ahcorde commented 4 years ago

rosidl_typesupport_c

rosidl_typesupport_c is using rosidl_generator_c headers which are located here rosidl_runtime_c

Also build_export_depend(rosidl_runtime_c) because headers should be exported https://www.ros.org/reps/rep-0140.html#build-export-depend-multiple

For example:

rosidl_typesupport_cpp

https://github.com/ros2/rosidl_typesupport/blob/master/rosidl_typesupport_cpp/include/rosidl_typesupport_cpp/message_type_support_dispatch.hpp#L18

Replaced here the right dependencies here:

https://github.com/ros2/rosidl_typesupport/blob/ahcorde/rosidl_runtime/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake#L119

rosidl_runtime_c is only need it, because there is no rosidl_runtime_cpp header used here

But we should build_export_depend rosidl_runtime_cpp because them it will be used by message packages

ahcorde commented 4 years ago

Last change refer to https://github.com/ros2/rosidl_python/pull/100#issuecomment-607169552

ahcorde commented 4 years ago 
CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

Windows