search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Removed poco dependency #59

Closed ahcorde closed 4 years ago

ahcorde commented 4 years ago

As part of the effort to remove Poco dependency described in this issue https://github.com/ros2/ros2/issues/867 this PR makes use of the recent changes in rcutils https://github.com/ros2/rcutils/pull/215 to load, unload and get symbols from shared libraries instead of using Poco.

Signed-off-by: ahcorde ahcorde@gmail.com

ahcorde commented 4 years ago

rcpputils PR is merged, can you review this ? @wjwwood or @dirk-thomas

ahcorde commented 4 years ago
ahcorde commented 4 years ago

Warning on Windows appears on spdlog_vendor which is strange because the code has not been modified for 15 days

14:24:43   CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.17/Modules/GNUInstallDirs.cmake:225 (message):
14:24:43     Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
14:24:43     target architecture is known.  Please enable at least one language before
14:24:43     including GNUInstallDirs.
14:24:43   Call Stack (most recent call first):
14:24:43     CMakeLists.txt:9 (include)
14:24:43   This warning is for project developers.  Use -Wno-dev to suppress it.