search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Same header file hosted in two packages: type_support_map.h #79

Closed j-rivero closed 3 years ago

j-rivero commented 3 years ago

Feature request

Feature description

The repository hosts a copy of the same file type_support_map.h in the two packages rosidl_typesupport_c and rosidl_typesupport_cpp. Not sure if that respond to a design decision or we could make rosidl_typesupport_cpp to use the one in rosidl_typesupport_c.

My first intention to change the code to implement that idea finished in a success build but before sending the PR I want to be sure that we want to go with it.

dirk-thomas commented 3 years ago

My first intention to change the code to implement that idea finished in a success build but before sending the PR I want to be sure that we want to go with it.

I don't understand the specific proposal but I don't see a reason why the definition of that struct couldn't be deduplicated. Please go ahead and propose a PR.

dirk-thomas commented 3 years ago

@j-rivero What is the status on this?

j-rivero commented 3 years ago

pull request is ready to review https://github.com/ros2/rosidl_typesupport/pull/81, just need some fixes in infrastructure to pass AFAIK.