search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

De-deplicate type_support_map.h header #81

Closed j-rivero closed 4 years ago

j-rivero commented 4 years ago

Fixes: #79

dirk-thomas commented 4 years ago

The removal of the public header file rosidl_typesupport_cpp/type_support_map.h is breaking public API. I would suggest to avoid that kind of breakage and keep the header in place (redirecting to the C header) and add a deprecation warning in case it is still used.

j-rivero commented 4 years ago

@ros-pull-request-builder run tests please

dirk-thomas commented 4 years ago

@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828)

j-rivero commented 4 years ago

ough the signoff amend command re-push a good bunch of commits, the ones did since your last comments are 4d9a6fa and 5f58fa2

dirk-thomas commented 4 years ago

Did you happen to run any CI builds for this change?

j-rivero commented 4 years ago

Did you happen to run any CI builds for this change?

eh uh ... totally forgot to run ros2 ci jobs, I just relied on the github CI mark. Go to check now.

j-rivero commented 4 years ago

eh uh ... totally forgot to run ros2 ci jobs, I just relied on the github CI mark. Go to check now.

Testing up to rclcpp, running rclcpp tests: