search

ros2 / rosidl_typesupport_connext

rosidl typesupport for RTI's Connext DDS.
Apache License 2.0
1 stars 9 forks source link

fix clang ignores #31

Closed dirk-thomas closed 5 years ago

dirk-thomas commented 5 years ago

Ignores these clang warnings: https://ci.ros2.org/job/ci_osx/5674/warnings11Result/

This patch uses the same pattern as in other locations (e.g. https://github.com/ros2/rosidl_typesupport_connext/pull/29/commits/43fccfd7f1dffec7b9ee07a9d7f3de96d26b82cf): Build Status

sloretz commented 5 years ago

FYI, same warnings in rmw_connext_shared_cpp

--- output: rmw_connext_shared_cpp
[ ... ]
[ 14%] Building CXX object CMakeFiles/rmw_connext_shared_cpp.dir/src/event.cpp.o
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/rmw_connext/rmw_connext_shared_cpp/src/event.cpp:18:
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/rmw_connext/rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/connext_static_event_info.hpp:18:
In file included from /Applications/rti_connext_dds-5.3.1/include/ndds/ndds_cpp.h:58:
In file included from /Applications/rti_connext_dds-5.3.1/include/ndds/ndds_c.h:83:
/Applications/rti_connext_dds-5.3.1/include/ndds/dds_c/dds_c_infrastructure.h:509:9: warning: 'register' storage class specifier is deprecated and incompatible with C++1z [-Wdeprecated-register]
        DDS_SequenceNumber_minusminus(this);
dirk-thomas commented 5 years ago

FYI, same warnings in rmw_connext_shared_cpp

@sloretz Can you point to where exactly you saw them? I just ran a CI build for rmw_connext_shared_cpp which doesn't show any: Build Status