search

ros2 / rosidl_typesupport_connext

rosidl typesupport for RTI's Connext DDS.
Apache License 2.0
1 stars 9 forks source link

Remove redundant logic #41

Closed jacobperron closed 4 years ago

jacobperron commented 4 years ago

Depends on https://github.com/ros2/rosidl/pull/432

dirk-thomas commented 4 years ago

Technically this one will need a minimum version dependency on the next version of rosidl_generator_c.

jacobperron commented 4 years ago

Technically this one will need a minimum version dependency on the next version of rosidl_generator_c.

Right. I can make a note for myself to add the version to the dependency when we release rosidl_generator_c.

jacobperron commented 4 years ago

For posterity, CI is here: https://github.com/ros2/rosidl/pull/432#issuecomment-576978604

jacobperron commented 4 years ago

Now that rosidl_generator_c is released, I've opened a follow-up adding the minimum version dependency: https://github.com/ros2/rosidl_typesupport_connext/pull/54