fix capacity of serialized messages

ros2 / rosidl_typesupport_connext

rosidl typesupport for RTI's Connext DDS.

Apache License 2.0

1 stars 9 forks source link

Closed dirk-thomas closed 4 years ago

dirk-thomas commented 4 years ago

Since the code was added originally in ros2/rmw_connext#259 the buffer_capacity of the rcutils_uint8_array_t wasn't updated after being reallocated. See http://build.ros2.org/view/Rci/job/Rci__nightly-connext_ubuntu_focal_amd64/29/testReport/rclcpp/TestSerializedMessage/serialization/ for a failing test because of that.

The patch is a bit more length since it makes sure to not partially modify the passed in rcutils_uint8_array_t when exiting with an error.

Karsten1987 commented 4 years ago

If we set the buffer capacity here, we should most likely revert this change here: https://github.com/ros2/rmw_connext/pull/417/files

dirk-thomas commented 4 years ago

If we set the buffer capacity here, we should most likely revert this change here: https://github.com/ros2/rmw_connext/pull/417/files

Please fill a separate issue for this if you think that code needs to be changed. It doesn't seem related to me.

dirk-thomas commented 4 years ago

CI builds with only Connext:

Linux
- Same test failures present on master (minus some in the meantime resolved ones):
macOS
- Same test failures present on master (minus some in the meantime resolved ones):
Windows
- Same test failures present on master (minus some in the meantime resolved ones):

hidmic commented 4 years ago

If I'm not mistaken, this could be backported to Foxy.