Fix flags for both clang and gcc.

ros2 / rviz

ROS 3D Robot Visualizer

BSD 3-Clause Clear License

296 stars 212 forks source link

Fix flags for both clang and gcc. #1219

Closed clalancette closed 3 months ago

clalancette commented 3 months ago

In particular, make sure that a clang-only flag (-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow).

This should fix #1217

clalancette commented 3 months ago

CI:

Linux
Linux-aarch64
Linux-rhel
Windows

ahcorde commented 3 months ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 3 months ago

backport jazzy

✅ Backports have been created

* [#1223 Fix flags for both clang and gcc. (backport #1219)](https://github.com/ros2/rviz/pull/1223) has been created for branch `jazzy`