search

ros2 / rviz

ROS 3D Robot Visualizer
BSD 3-Clause Clear License
306 stars 214 forks source link

Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscreen mode #1228

Closed bochen87 closed 3 months ago

bochen87 commented 4 months ago

Fixes #1024

ahcorde commented 4 months ago
bochen87 commented 4 months ago

Do you mind to merge with rolling ? then CI warnings should disappeared

sure, how do i do that?

ahcorde commented 3 months ago

You can type something like this

git fetch
git merge origin/rolling
git push origin rolling
ahcorde commented 3 months ago
bochen87 commented 3 months ago

@ahcorde Can we also backport this to jazzy?

ahcorde commented 3 months ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 3 months ago

backport jazzy

✅ Backports have been created

* [#1250 Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscreen mode (backport #1228)](https://github.com/ros2/rviz/pull/1250) has been created for branch `jazzy`
bochen87 commented 3 months ago

https://github.com/Mergifyio backport jazzy

Thanks for backporting! Is it possible to tag a new version so it get's released in the next cycle?

ahcorde commented 3 months ago

https://github.com/Mergifyio backport jazzy

Thanks for backporting! Is it possible to tag a new version so it get's released in the next cycle?

https://github.com/ros/rosdistro/pull/42481