search

ros2 / rviz

ROS 3D Robot Visualizer
BSD 3-Clause Clear License
273 stars 207 forks source link

Release rviz_assimp_vendor as independent assimp_vendor package? #886

Open ijnek opened 1 year ago

ijnek commented 1 year ago

The rviz_assimp_vendor package is used to build assimp on platforms that don't have a system dependency available for assimp.

According to ROS Index, assimp is used across at least 5 released packages in rolling, so I believe there is benefit in moving this out to a standalone assimp_vendor package.

(Same goes for freetype and zlib, which is dealt inside rviz_ogre_vendor)

Are there some reasons against this move, apart from having greater control over assimp by keeping it rviz specific?

clalancette commented 1 year ago

I'd be for moving this to general vendored packages. While we are at it, I'd love to make them use the system versions when they can.

ijnek commented 1 year ago

Great, what's the best way to proceed? I've gone ahead and moved the package out into its own repo already - https://github.com/ijnek/assimp_vendor. Should we aim to transfer this repo to ros2, or ..?