ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 45 forks source link

[Dashing/Eloquent] List keys doesn't list nested keys #183

Closed ivanpauno closed 4 years ago

ivanpauno commented 4 years ago

Bug report

Required Info:

Steps to reproduce issue

ros2 security generate_artifacts -k tmp -n /node1 /ns/node1 /ns/node2
ros2 security list_keys tmp

Expected behavior

Output:

/node1
/ns/node1
/ns/node2

Actual behavior

Output:

node1
ns

Additional information

This should be fixed for Dashing/Eloquent, and also for Foxy after https://github.com/ros2/sros2/pull/177 is merged. Add a regression test too.

hidmic commented 4 years ago

@ros2/security_working_group are you planning to take a stab at this one in the near term e.g. before Foxy feature freeze?

kyrofa commented 4 years ago

Do the still-in-flux design updates impact this at all?

ivanpauno commented 4 years ago

Do the still-in-flux design updates impact this at all?

The fixes for Dashing and Eloquent aren't blocked by those changes. About Foxy, maybe contexts folder is renamed to enclaves, but it isn't a big deal to update the folder name in a follow up.

ivanpauno commented 4 years ago

Reopening to track the fix for Dashing/Eloquent

mikaelarguedas commented 4 years ago

Backported and released Dashing: https://github.com/ros2/sros2/pull/223 https://github.com/ros/rosdistro/pull/25499 Eloquent: https://github.com/ros2/sros2/pull/222 https://github.com/ros/rosdistro/pull/25492