search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
90 stars 45 forks source link

Permission validity should be configurable #186

Open mikaelarguedas opened 4 years ago

mikaelarguedas commented 4 years ago

Feature request

Feature description

Generated permissions file should use the same validity period as the certificates. Currently they use hard coded timeframe that expires in 2023 https://github.com/ros2/sros2/blob/9e1d10578e1ccf0d08c41ee5c06e0968878143f6/sros2/sros2/policy/templates/dds/permissions.xsl#L12

Implementation considerations

Certificates currently use [UTC:UTC+10years] https://github.com/ros2/sros2/blob/9e1d10578e1ccf0d08c41ee5c06e0968878143f6/sros2/sros2/api/__init__.py#L451 The same could be used.

Ideally the user would be able to specify the start date and the dureation. That range would be applied to both the certificates and permissions files

kyrofa commented 4 years ago

The same could be used.

That sounds like a bug, and could be fixed after feature freeze.

Ideally the user would be able to specify the start date and the duration.

Yeah, that's more of a feature.

hidmic commented 4 years ago

@kyrofa @mikaelarguedas are you planning to land said feature for Foxy?

kyrofa commented 4 years ago

It's after feature freeze now, so I suspect we'll go the bugfix route on this one.

dirk-thomas commented 4 years ago

I don't know what this needs to be merged but we haven't frozen yet. It might still be ~ a day out.

mikaelarguedas commented 4 years ago

I won't work on this in the next couple days. I should be able to provide a bugfix to have matching validity dates next week

mikaelarguedas commented 4 years ago

bugfix submitted at https://github.com/ros2/sros2/pull/205