search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
90 stars 45 forks source link

security-context -> enclave #198

Closed mikaelarguedas closed 4 years ago

mikaelarguedas commented 4 years ago

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #198 into master will not change coverage by %. The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files          16       16           
  Lines         565      565           
  Branches       52       52           
=======================================
  Hits          339      339           
  Misses        212      212           
  Partials       14       14
Flag Coverage Δ
#unittests 60.00% <80.00%> (ø)
Impacted Files Coverage Δ
sros2/sros2/api/_artifact_generation.py 0.00% <0.00%> (ø)
sros2/sros2/verb/generate_artifacts.py 0.00% <ø> (ø)
sros2/sros2/api/_policy.py 85.71% <66.66%> (ø)
sros2/sros2/api/_key.py 90.14% <100.00%> (ø)
sros2/sros2/api/_keystore.py 84.72% <100.00%> (ø)
sros2/sros2/api/_permission.py 92.30% <100.00%> (ø)
sros2/sros2/verb/create_key.py 80.00% <100.00%> (ø)
sros2/sros2/verb/create_permission.py 68.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ea3858...b4d7709. Read the comment docs.

mikaelarguedas commented 4 years ago

CI for this and connected PRs:

https://github.com/ros2/rcl/pull/612 https://github.com/ros2/rmw/pull/211 https://github.com/ros2/rmw_connext/pull/407 https://github.com/ros2/rmw_cyclonedds/pull/146 https://github.com/ros2/rmw_dds_common/pull/13 https://github.com/ros2/rmw_implementation/pull/91 https://github.com/ros2/rmw_fastrtps/pull/365 https://github.com/ros2/sros2/pull/198 https://github.com/ros2/system_tests/pull/414

Repos file at https://gist.githubusercontent.com/mikaelarguedas/cd1009797d836e6d46a0f6d12b1cc05d/raw/2770591673f28d73d21ea5d432d939fee171e75d/enclaves.repos

@ivanpauno AFAICT all these test failures are also present in the nightly jobs. Please let me know if you know of any that may have been borken by this set of PRs

ivanpauno commented 4 years ago

@ivanpauno AFAICT all these test failures are also present in the nightly jobs. Please let me know if you know of any that may have been borken by this set of PRs

Please, run windows job again only with one rmw implementation. We have recently got rid of Poco and something seems to be broken now.

The other platforms looks ok.

mikaelarguedas commented 4 years ago

Please, run windows job again only with one rmw implementation. We have recently got rid of Poco and something seems to be broken now.

gotcha

Connext only, using updated rcl after resolving merge conflicts

mikaelarguedas commented 4 years ago

Another round of CI after rebasing all PRs CI only with connext to avoid Windows build failure Build and testing only rcl and sros2

mikaelarguedas commented 4 years ago

Looks like windows rcl is broken... seems unrelated to this set of PRs though. rcl master build to compare: Build Status @ivanpauno can we go ahead and merge all these renaming PRs? or do you want to wait for the windows issue on master to be fixed first?

ruffsl commented 4 years ago

Just skimming the test results from Build Status , it seems that test_rcl_get_node_names_with_security_contexts failed, but wasn't that renamed using enclave here: https://github.com/ros2/rcl/pull/612/files#diff-6dd792d0229de5c8296858ba7649a6d3R168

Is the job using all the latest commits in the PR?

mikaelarguedas commented 4 years ago

That job is running on master to show that all rcl tests on master are broken. It doesn't include any change from these PRs.

Updated https://github.com/ros2/sros2/pull/198#issuecomment-612247922 to make it clearer