search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Fix name of argument passed to NodeStrategy #227

Closed jacobperron closed 4 years ago

jacobperron commented 4 years ago

Fixes #226

NodeStrategy does not look for an argument named 'use_daemon'. Instead it checks for an argument named 'no_daemon'.

macOS (retest-until-fail 10): Build Status

artivis commented 4 years ago

For reference: NodeStrategy looking for no_daemon.

codecov[bot] commented 4 years ago

Codecov Report

Merging #227 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files          23       23           
  Lines         609      609           
  Branches       53       53           
=======================================
  Hits          468      468           
  Misses        121      121           
  Partials       20       20
Flag Coverage Δ
#unittests 76.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbec91d...25633f8. Read the comment docs.

mikaelarguedas commented 4 years ago

Permalink for the reference from https://github.com/ros2/sros2/pull/227#issuecomment-655002653

https://github.com/ros2/ros2cli/blob/95bfb056df795b6eef8bb73b165db31fcf2d867a/ros2cli/ros2cli/node/strategy.py#L26