j-rivero commented 4 years ago

Following upstream instructions https://docs.pytest.org/en/stable/fixture.html#scope-sharing-fixtures-across-classes-modules-packages-or-session . Fix #229

Testing:

Linux
Aarch64
Win
OsX

j-rivero commented 4 years ago

Thanks for this, @j-rivero. Mind signing off on your commit?

sure, sorry for that.

kyrofa commented 4 years ago

and it's already done !

That's how @j-rivero rolls. You think it and it happens!

codecov[bot] commented 4 years ago

Codecov Report

Merging #230 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files          23       23           
  Lines         609      609           
  Branches       53       53           
=======================================
  Hits          468      468           
  Misses        121      121           
  Partials       20       20

Flag	Coverage Δ
#unittests	`76.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54e80d5...f4d58d8. Read the comment docs.

ros2 / sros2

Add scope parameter to conftest.py #230

Codecov Report