ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

add cyclonedds to the list of rmw using graph info topics #231

Closed mikaelarguedas closed 4 years ago

mikaelarguedas commented 4 years ago

To test if it fixes the issue of CI failing with cyclone and security from https://github.com/ros2/system_tests/pull/408

Necessary since https://github.com/ros2/rmw_cyclonedds/pull/145 particularily this bit https://github.com/ros2/rmw_cyclonedds/blob/3bfe094b60c1a3116b1f2c09c845a745fd240987/rmw_cyclonedds_cpp/src/rmw_node.cpp#L1026-L1035

codecov[bot] commented 4 years ago

Codecov Report

Merging #231 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files          23       23           
  Lines         609      609           
  Branches       53       53           
=======================================
  Hits          468      468           
  Misses        121      121           
  Partials       20       20           
Flag Coverage Δ
#unittests 76.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sros2/sros2/api/_permission.py 93.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 219dd9f...9eceb19. Read the comment docs.

mikaelarguedas commented 4 years ago

This fixed the failures at https://github.com/ros2/system_tests/pull/408#issuecomment-667171125

Marking this as ready for review

mikaelarguedas commented 4 years ago

may need to be backported to foxy depending on https://github.com/ros2/ros2/pull/999

ros-discourse commented 4 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-08-20/16063/1