search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Add scope parameter (backport to Foxy) #232

Closed j-rivero closed 4 years ago

j-rivero commented 4 years ago

Backporting #230 to Foxy to solve regressions in test. //cc @jacobperron

codecov[bot] commented 4 years ago

Codecov Report

Merging #232 into foxy will decrease coverage by 1.71%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             foxy     #232      +/-   ##
==========================================
- Coverage   78.02%   76.31%   -1.72%     
==========================================
  Files          16       17       +1     
  Lines         578      591      +13     
  Branches       51       53       +2     
==========================================
  Hits          451      451              
- Misses        107      120      +13     
  Partials       20       20
Flag Coverage Δ
#unittests 76.31% <ø> (-1.72%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sros2/setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8263f68...3e80530. Read the comment docs.

mikaelarguedas commented 4 years ago

The coverage decrease seems invalid as the coverage of this PR diff is unchanged. So ignoring the codecov failure and merging as is