ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Wrong instruction in SROS2_Linux.md #235

Closed JaehyunShim closed 3 years ago

JaehyunShim commented 4 years ago

Hi @mikaelarguedas

I tested sros2 following the instruction written in the SROS2_Linux.md file and found some information wrong. It has to be fixed as written in my pull request or as below.

$ scp -r * USERNAME@oldschool.local:~/sros2_demo/demo_keys but above will also copy keys for all the other nodes, which is not desirable.

Ryan

mikaelarguedas commented 4 years ago

Thanks @rjshim for bringing this up, you're right the instructions have not been updated recently to reflect the keystore structure change, although they work exactly as before by copying the entire keystore over.

Can you confirm if in its current state the tutorial worked for you ?


When narrowing down the files being copied over (which is a good thing to do :+1:), I think you still need to copy the "public" folder, otherwise the identity and permissions CA public artifacts will not be available on the target machine (as they are symlinks)

root@1c4fae59ff19:~/demo_keys/keystore# ls -l enclaves/talker_listener/talker/identity_ca.cert.pem 
lrwxrwxrwx 1 root root 36 Sep  2 21:16 enclaves/talker_listener/talker/identity_ca.cert.pem -> ../../../public/identity_ca.cert.pem
JaehyunShim commented 4 years ago

@mikaelarguedas

Thank you for your reply. Since I do not know how the whole system work, I do not know why but it worked without copying the file you mentioned.

[Talker side] 1) Dir/File list Screenshot from 2020-09-07 11-48-01 2) Pub topics Screenshot from 2020-09-07 11-44-58

[Listener side] 1) Sub topics Screenshot from 2020-09-07 11-44-47

Thank you, Ryan

JaehyunShim commented 3 years ago

ping @mikaelarguedas