search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Expose keystore operations in public API #241

Closed kyrofa closed 3 years ago

kyrofa commented 3 years ago

This PR resolves #237 by creating a new public sros2.keystore package exposing the following public functions:

codecov[bot] commented 3 years ago

Codecov Report

Merging #241 into master will increase coverage by 0.41%. The diff coverage is 77.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   76.84%   77.25%   +0.41%     
==========================================
  Files          23       25       +2     
  Lines         609      664      +55     
  Branches       53       55       +2     
==========================================
+ Hits          468      513      +45     
- Misses        121      131      +10     
  Partials       20       20
Flag Coverage Δ
#unittests 77.25% <77.58%> (+0.41%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sros2/setup.py 0.00% <ø> (ø)
sros2/sros2/api/_artifact_generation.py 0.00% <0.00%> (ø)
sros2/sros2/verb/generate_artifacts.py 0.00% <0.00%> (ø)
sros2/sros2/verb/create_enclave.py 69.23% <69.23%> (ø)
sros2/sros2/verb/create_permission.py 67.85% <72.72%> (-0.15%) :arrow_down:
sros2/sros2/errors.py 74.19% <74.19%> (ø)
sros2/sros2/verb/create_keystore.py 71.42% <76.92%> (-7.15%) :arrow_down:
sros2/sros2/verb/generate_policy.py 86.11% <80.00%> (-1.86%) :arrow_down:
sros2/sros2/verb/list_enclaves.py 82.14% <82.14%> (ø)
sros2/sros2/keystore/_keystore.py 88.33% <88.33%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d57584...3887dd2. Read the comment docs.

ros-discourse commented 3 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-agenda-2020-09-17/16464/1

kyrofa commented 3 years ago

The 'tuto' (e.g. SROS2_Linux.md) probably need an update too

Good call, I updated all three.

kyrofa commented 3 years ago

Could we clarify here (or in a meta ticket referencing this PR) in what list of action items this fits and what are the expected follow-up action items for this to be part of a Rolling/Galactic release?

I think this stands alone. As you know (and as outlined in #237) we have other things that we expect will be useful as part of the public API, but the changes in this PR represent all that is required for the only known consumer of our API. I wouldn't say those additional changes are required for this to qualify to be part of rolling/galactic.

kyrofa commented 3 years ago

@mikaelarguedas friendly ping on this.

mikaelarguedas commented 3 years ago

@ros-pull-request-builder could you retest this please ?

kyrofa commented 3 years ago
ros-discourse commented 3 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-10-15/16849/1