search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

no CI against nightly or latest on foxy branch #243

Closed mikaelarguedas closed 3 years ago

mikaelarguedas commented 3 years ago

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

kyrofa commented 3 years ago

This seems to remove CI completely, can we at least get CI against Foxy?

mikaelarguedas commented 3 years ago

The CI from the buildfarm is available for released distros. e.g. on this PR we get the jobs Fpr__sros2__* triggered automatically

artivis commented 3 years ago

So we keep the CI for unreleased branches and hands it off to the build farm for released ones? How does that work wrt Rolling?

kyrofa commented 3 years ago

How does that work wrt Rolling?

Good question, I wonder if the build farm supports running tests against rolling now. I suspect it does. I'm also not sure what it really gets us beyond our current tests in master, though.

clalancette commented 3 years ago

Good question, I wonder if the build farm supports running tests against rolling now. I suspect it does. I'm also not sure what it really gets us beyond our current tests in master, though.

It depends on which buildfarm you are talking about. https://ci.ros2.org/ runs all of the tests from all core packages on all tier 1 platforms nightly.

http://build.ros2.org has PR jobs, which are the ones that show up in the Github "checks" here. Which PR job is used depends on which branch a PR targets. For ones that target foxy, for instance, the PR job is http://build.ros2.org/view/Fpr/job/Fpr__sros2__ubuntu_focal_amd64/. For ones that target master, the PR job is: http://build.ros2.org/view/Rpr/job/Rpr__sros2__ubuntu_focal_amd64/ . In either case, those PR jobs run all of the tests for this particular repository on every PR that is opened, though only on Linux/amd64.

Hope that answers your question.

mikaelarguedas commented 3 years ago

So we keep the CI for unreleased branches and hands it off to the build farm for released ones? How does that work wrt Rolling?

Yes I think that's what we'll do for now. The limiting thing is that (for now both on CI on this repo and for buildfarm PR jobs) we test only ubuntu so it's not covering any of the other platforms..

For Rolling, the release strategy is unclear, for now the version in rolling was automatically released by OR so it is using the branch and package version that was used by the foxy release at the time. We'll need to decide what we release in rolling, if it just tags off master or if we make a rolling branch, on what schedule to release and how we test it (noting that our CI options have the same limitations ATM so onlu ubuntu testing). Right now I'm leaning towards no dedicated branch, releasing off the default branch and doing thorough testing only when we need to use whats in rolling to kick-off a new distro. So Rolling CI will just be our usual master-branch testing

kyrofa commented 3 years ago

Right now I'm leaning towards no dedicated branch, releasing off the default branch and doing thorough testing only when we need to use whats in rolling to kick-off a new distro. So Rolling CI will just be our usual master-branch testing

I agree with that.