ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
90 stars 45 forks source link

Fix namedtuple names. #250

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

According to the documentation for namedtuple:

"To support pickling, the named tuple class should be assigned to a variable that matches typename."

The newest version of mypy (0.800) now has a warning for this as well. Change the name that is the first argument to eliminate this warning.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 3 years ago

CI:

codecov[bot] commented 3 years ago

Codecov Report

Merging #250 (2b19312) into master (58dc4b4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   77.25%   77.25%           
=======================================
  Files          25       25           
  Lines         664      664           
  Branches       55       55           
=======================================
  Hits          513      513           
  Misses        131      131           
  Partials       20       20           
Flag Coverage Δ
unittests 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sros2/sros2/_utilities.py
sros2/sros2/api/_policy.py
sros2/sros2/verb/__init__.py
sros2/sros2/keystore/_keystore.py
sros2/sros2/policy/__init__.py
sros2/setup.py
sros2/sros2/policy/templates/__init__.py
sros2/sros2/policy/schemas/dds/__init__.py
sros2/sros2/verb/create_enclave.py
sros2/sros2/keystore/__init__.py
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74da58f...2b19312. Read the comment docs.