search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Change rmw_connext_cpp -> rmw_connextdds. #255

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #255 (82575b1) into master (a02492f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   77.25%   77.25%           
=======================================
  Files          25       25           
  Lines         664      664           
  Branches       55       55           
=======================================
  Hits          513      513           
  Misses        131      131           
  Partials       20       20
Flag Coverage Δ
unittests 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...wp79c/sros2/sros2/sros2/policy/schemas/__init__.py
.../sros2/sros2/sros2/policy/defaults/dds/__init__.py
...o8wwp79c/sros2/sros2/sros2/keystore/_permission.py
...c/dz5o8wwp79c/sros2/sros2/sros2/policy/__init__.py
...c/sros2/sros2/sros2/policy/schemas/dds/__init__.py
...dz5o8wwp79c/sros2/sros2/sros2/keystore/_enclave.py
...dz5o8wwp79c/sros2/sros2/sros2/keystore/__init__.py
...s/src/dz5o8wwp79c/sros2/sros2/sros2/api/_policy.py
ros_ws/src/dz5o8wwp79c/sros2/sros2/setup.py
.../dz5o8wwp79c/sros2/sros2/sros2/command/security.py
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a02492f...82575b1. Read the comment docs.

ivanpauno commented 3 years ago

should be merged after https://github.com/ros2/ros2/pull/1116

clalancette commented 3 years ago

@SidFaber @mikaelarguedas A second review here would be appreciated (it is only changes to the documentation, so should be minor). Thanks in advance.

clalancette commented 3 years ago

CI for this was in https://github.com/ros2/rmw_connextdds/issues/9#issuecomment-805863900 (the yellow builds were because of an uncrustify failure in rclcpp that has since been fixed). So I'll go ahead and merge this, thanks everyone for the reviews.