search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Bump discovery delay when using RTI Connext-based RMWs #257

Closed hidmic closed 3 years ago

hidmic commented 3 years ago

First dumb attempt to deal with test_generate_policy flakes when running against rmw_connextdds (e.g. https://ci.ros2.org/view/nightly/job/nightly_osx_repeated/lastCompletedBuild/testReport/sros2.test.sros2.commands.security.verbs/test_generate_policy/test_generate_policy/).

CI up to sros2 against rmw_connextdds only:

codecov[bot] commented 3 years ago

Codecov Report

Merging #257 (72dc3f9) into master (c0801b8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   77.25%   77.25%           
=======================================
  Files          25       25           
  Lines         664      664           
  Branches       55       55           
=======================================
  Hits          513      513           
  Misses        131      131           
  Partials       20       20
Flag Coverage Δ
unittests 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...wmozlsrd/sros2/sros2/sros2/keystore/_permission.py
ros_ws/src/rrwmozlsrd/sros2/sros2/sros2/errors.py
...d/sros2/sros2/sros2/policy/schemas/dds/__init__.py
...srd/sros2/sros2/sros2/policy/templates/__init__.py
...rwmozlsrd/sros2/sros2/sros2/verb/create_enclave.py
...rc/rrwmozlsrd/sros2/sros2/sros2/policy/__init__.py
...rrwmozlsrd/sros2/sros2/sros2/verb/list_enclaves.py
.../rrwmozlsrd/sros2/sros2/sros2/keystore/_enclave.py
...os_ws/src/rrwmozlsrd/sros2/sros2/sros2/__init__.py
.../rrwmozlsrd/sros2/sros2/sros2/keystore/__init__.py
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0801b8...72dc3f9. Read the comment docs.

clalancette commented 3 years ago

Still flaked on Linux :(.

hidmic commented 3 years ago

Let's try another bump. It's not a real solution, but there's no way we can do an integration test for this command that's not sensitive to discovery latency.

hidmic commented 3 years ago

I suspect this test is wrong. Waiting for the test itself to discover the fixture nodes does not imply the daemon has. Dropping in favor of #260.