ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Eloquent instructions are incorrect #266

Closed LanderU closed 3 years ago

LanderU commented 3 years ago

Bug report

Required Info:

Steps to reproduce issue

docker run -it osrf/ros-eloquent-desktop
$ apt update && apt install subversion -y
$ mkdir ~/sros2
$ cd ~/sros2/
$ svn checkout https://github.com/ros2/sros2/trunk/sros2/test/policies
root@8ff9a792bff0:~/sros2# ros2 security create_permission demo_keys /talker policies/sample_policy.xml
policy file 'policies/sample_policy.xml' does not exist
root@8ff9a792bff0:~/sros2/policies# ls
add_two_ints.policy.xml  common  minimal_action.policy.xml  permissions  policy_to_permissions.py  sample.policy.xml  single_context.policy.xml  talker_listener.policy.xml
root@8ff9a792bff0:~/sros2# ros2 security create_permission demo_keys /talker policies/sample.policy.xml 
Element 'enclaves': This element is not expected. Expected is ( profiles )., line 4

Expected behavior

Be able to use policies version for eloquent.

Actual behavior

Looks like the version of the policies are not well pinned in the SROS2_Linux.md version.

Additional information


Feature request

Feature description

Implementation considerations

clalancette commented 3 years ago

Eloquent is end of life, so we probably won't be doing any further updates for it. My suggestion is that you try out Galactic or Foxy instead.

I think this should probably be closed, but I'll leave that to the SROS 2 maintainers to do.

ruffsl commented 3 years ago

You'll want to use the templates from before in introduction of enclaves, so before foxy and Apr 2020: https://github.com/ros2/sros2/commits/master/sros2/test/policies

LanderU commented 3 years ago

@ruffsl @clalancette, thanks a lot for your responses!