search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
89 stars 44 forks source link

Add domain id argument #268

Closed danthony06 closed 2 years ago

danthony06 commented 3 years ago

Addresses https://github.com/ros2/sros2/issues/267. I haven't worked with SROS2 before, so apologies in advance for anything I have messed up.

Distro A, OPSEC #4584

mikaelarguedas commented 3 years ago

Thanks for the PR! I'll try to find time to go over it this weekend.

Ideally the argument would be optional in the command line and all functions, otherwise it will be breaking API making that PR not suitable for galactic and would have to be held until the next ROS release.

danthony06 commented 3 years ago

@mikaelarguedas I added a fallback so that if the command line argument is not provided, it should fall back and check the environment variable and maintain the same behavior. @ruffsl does not seem as excited by this, so do you think I should keep working on this?

ruffsl commented 3 years ago

@ruffsl do you think such config file will be implemented in the near future ? Would you consider it a blocker for this incremental improvement ?

We could go through with this incremental addition to the CLI, but I'd just like to ensure we are comfortable reverting this once a proper user config file is supported. Adding transport specific arguments to the CLI just doesn't seem very scalable.

I could also propose a config format during the next Security WG meeting, but in the meantime I think we should step back and do a compressive audit of all the finer parameters and settings we'd like to expose or default for end users, e.g. Secure DDS governance options, CA hierarchy, etc.