search

ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
90 stars 45 forks source link

Fix a number of warnings on Ubuntu 24.04. #289

Closed clalancette closed 8 months ago

clalancette commented 8 months ago

In particular:

  1. Get rid of the fallback path for argcompleter. It isn't necessary anymore since all versions of argcompleter support these, and it was confusing mypy.
  2. Add in a proper Optional annotation.
  3. Use the newer importlib_resources.file API when it is available.
clalancette commented 8 months ago

CI is failing because we don't always install python3-argcomplete on all of our platforms. However, I think that is just wrong, since that is the experience we want to give to users. There are 2 fixes here:

  1. Add a dependency on python3-argcomplete to this package.
  2. Update our CI scripts to install python3-argcomplete as necessary.

I'll fix up this PR with 1, and open a separate PR for 2.

fujitatomoya commented 8 months ago

CI:

fujitatomoya commented 8 months ago

Ah, sorry CI is not ready yet? if so, previous CI is expected to fail again.

clalancette commented 8 months ago

Ah, sorry CI is not ready yet? if so, previous CI is expected to fail again.

That's right, it wasn't ready yet. But it now is. I ran CI for this over in https://github.com/ros2/ci/pull/746#issuecomment-1919128339 , and it was happy. So going ahead and merging this one now.