Open mikaelarguedas opened 6 months ago
@marcoag @clalancette is it possible to launch a round of CI for this PR please :pray:
@ruffsl interested in having your feedback on this.
(all info in the description of the PR)
CI on WIndows is failing because CI is using a lower version of Python than the one defined in REP-2000. More details at https://github.com/ros-infrastructure/ros2-cookbooks/pull/69
CI on WIndows is failing because CI is using a lower version of Python than the one defined in REP-2000. More details at ros-infrastructure/ros2-cookbooks#69
I commented over there, but in short, we are not going to be able to update Python. So we'll have to figure out another solution.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.38%. Comparing base (
0b6ac75
) to head (03a1e3e
). Report is 10 commits behind head on rolling.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
~@ahcorde @clalancette is it possible to launch CI on that version to see if Windows is happy with it ?~
@marcoag mind giving this a try with connect? 🧇
This PR (basically a redo of https://github.com/ros2/sros2/pull/210) does:
I dont have a connext setup (license plugins etc right now) and the ROS 2 CI machines seem to be UTC so maybe they wont reflect the issue. If a reviewer that is behind UTC and has the right setup can give it a try that'd be awesome