ros2 / sros2

tools to generate and distribute keys for SROS 2
Apache License 2.0
90 stars 46 forks source link

[TESTS] Update tests and add test for generate_artifacts #311

Closed mikaelarguedas closed 6 months ago

mikaelarguedas commented 6 months ago
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.92%. Comparing base (3882441) to head (a1296a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## rolling #311 +/- ## ============================================ + Coverage 77.35% 88.92% +11.57% ============================================ Files 25 24 -1 Lines 627 614 -13 Branches 66 64 -2 ============================================ + Hits 485 546 +61 + Misses 121 50 -71 + Partials 21 18 -3 ``` | [Flag](https://app.codecov.io/gh/ros2/sros2/pull/311/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros2) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros2/sros2/pull/311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros2) | `88.92% <ø> (+11.57%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikaelarguedas commented 6 months ago
mikaelarguedas commented 6 months ago

i do not have maintenance permission for this repo, but i did review the code so posting lgtm.

Thanks @fujitatomoya for the review!

@ruffsl @artivis @florcabral ok for you ?

mikaelarguedas commented 6 months ago

Thanks!

mikaelarguedas commented 6 months ago

@Mergifyio backport jazzy

mergify[bot] commented 6 months ago

backport jazzy

✅ Backports have been created

* [#319 [TESTS] Update tests and add test for generate_artifacts (backport #311)](https://github.com/ros2/sros2/pull/319) has been created for branch `jazzy`