ros2 / tinydir_vendor

Vendor package for providing tinydir within a cmake package
Apache License 2.0
0 stars 7 forks source link

CMake warning: Missing `project()` command #17

Closed rotu closed 4 years ago

rotu commented 4 years ago

CI warning: https://ci.ros2.org/job/ci_windows/10157/consoleText

-- Build files have been written to: C:/ci/ws/build/tinydir_vendor
Microsoft (R) Build Engine version 16.5.0+d4cbfca49 for .NET Framework

Copyright (C) Microsoft Corporation. All rights reserved.

  Checking Build System

  Creating directories for 'tinydir-1.2.4'

  Building Custom Rule C:/ci/ws/src/ros2/tinydir_vendor/CMakeLists.txt

  Performing download step (download, verify and extract) for 'tinydir-1.2.4'

  -- Downloading...

     dst='C:/ci/ws/build/tinydir_vendor/tinydir-1.2.4/src/1.2.4.tar.gz'

     timeout='none'

  -- Using src='https://github.com/cxong/tinydir/archive/1.2.4.tar.gz'

  -- [download 100% complete]

  -- verifying file...

         file='C:/ci/ws/build/tinydir_vendor/tinydir-1.2.4/src/1.2.4.tar.gz'

  -- Downloading... done

  -- extracting...

       src='C:/ci/ws/build/tinydir_vendor/tinydir-1.2.4/src/1.2.4.tar.gz'

       dst='C:/ci/ws/build/tinydir_vendor/tinydir-1.2.4/src/tinydir-1.2.4'

  -- extracting... [tar xfz]

  -- extracting... [analysis]

  -- extracting... [rename]

  -- extracting... [clean up]

  -- extracting... done

  No update step for 'tinydir-1.2.4'

  Performing patch step for 'tinydir-1.2.4'

  Performing configure step for 'tinydir-1.2.4'

  CMake Warning (dev) in CMakeLists.txt:

    No project() command is present.  The top-level CMakeLists.txt file must

    contain a literal, direct call to the project() command.  Add a line of

    code such as

      project(ProjectName)

    near the top of the file, but after cmake_minimum_required().

    CMake is pretending there is a "project(Project)" command on the first

    line.

  This warning is for project developers.  Use -Wno-dev to suppress it.
mjcarroll commented 4 years ago

It looks like you landed this patch on master, but the eloquent branch wasn't updated. Since there aren't any other substantial changes, and this dependency has been dropped from foxy, I'm going to fast-forward the eloquent branch up to master.

mjcarroll commented 4 years ago

And verification that the warning is gone:

mjcarroll commented 4 years ago

Thanks for reporting @rotu, looks to be cleared up.