search

ros2 / tinyxml2_vendor

temporary vendor package for tinyxml2
Apache License 2.0
2 stars 9 forks source link

Do not call find_package() if package has already been found #17

Closed rjoomen closed 1 year ago

rjoomen commented 1 year ago

This greatly speeds up complex builds, as a lot of time was spent by repeated calls to find_package() from FindTinyXML2.cmake

rjoomen commented 1 year ago

Would you like me to PR this to all branches?

clalancette commented 1 year ago

Would you like me to PR this to all branches?

rolling first, please. Once it is accepted there we'll use the bot to backport it.

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

@Mergifyio backport humble iron

mergify[bot] commented 1 year ago

backport humble iron

✅ Backports have been created

* [#19 Do not call find_package() if package has already been found (backport #17)](https://github.com/ros2/tinyxml2_vendor/pull/19) has been created for branch `humble` * [#18 Do not call find_package() if package has already been found (backport #17)](https://github.com/ros2/tinyxml2_vendor/pull/18) has been created for branch `iron`