search

ros2 / tinyxml2_vendor

temporary vendor package for tinyxml2
Apache License 2.0
2 stars 9 forks source link

Account for potential target namespace when finding cmake module... #2

Closed jacobperron closed 5 years ago

jacobperron commented 5 years ago

for tinyxml2.

Resolves ros2/build_cop#156

jacobperron commented 5 years ago

Looks like the namespace is not required when linking.

jacobperron commented 5 years ago

Test on CI machine with latest tinyxml2 release: Build Status

Requires ros2/Fast-RTPS (find_tinyxml2_update).

jacobperron commented 5 years ago

Regular CI (includes MacOS with older tinyxml2 release to test backwards compatibility):

jacobperron commented 5 years ago

Take 2:

jacobperron commented 5 years ago

Take 3:

jacobperron commented 5 years ago

The test CI job made it past the tinyxml related errors and is stuck on an unrelated error.

Rebuild Windows: Build Status :crossed_fingers:

jacobperron commented 5 years ago
nuclearsandwich commented 5 years ago 
03:57:23 -- Found fastrtps_cmake_module: 0.6.0 (/home/rosbuild/ci_scripts/ws/install/fastrtps_cmake_module/share/fastrtps_cmake_module/cmake)
03:57:23 CMake Error at /home/rosbuild/ci_scripts/ws/install/fastrtps/share/fastrtps/cmake/fastrtps-config.cmake:50 (find_package):
03:57:23   By not providing "FindTinyXML2.cmake" in CMAKE_MODULE_PATH this project has
03:57:23   asked CMake to find a package configuration file provided by "TinyXML2",
03:57:23   but CMake did not find one.
03:57:23 
03:57:23   Could not find a package configuration file provided by "TinyXML2" with any
03:57:23   of the following names:
03:57:23 
03:57:23     TinyXML2Config.cmake
03:57:23     tinyxml2-config.cmake
03:57:23 
03:57:23   Add the installation prefix of "TinyXML2" to CMAKE_PREFIX_PATH or set
03:57:23   "TinyXML2_DIR" to a directory containing one of the above files.  If
03:57:23   "TinyXML2" provides a separate development package or SDK, be sure it has
03:57:23   been installed.
03:57:23 Call Stack (most recent call first):
03:57:23   CMakeLists.txt:38 (find_package)
jacobperron commented 5 years ago

After update to eProsima/Fast-RTPS#349:

mjcarroll commented 5 years ago

Looks like network issues for both of these, rebuilding.

nuclearsandwich commented 5 years ago

The VCS import failed again. When I try to import that repos file locally I get

=== src/ros2/Fast-RTPS (git) ===
Could not checkout ref 'find_tinyxml2_update': error: pathspec 'find_tinyxml2_update' did not match any file(s) known to git.

Since Fast-RTPS has merged https://github.com/eProsima/Fast-RTPS/pull/349 here is the same again with just this branch.

:apple: Build Status :wind_chime: (queued) Build Status

jacobperron commented 5 years ago

Aaand the updated :apple: Build Status

nuclearsandwich commented 5 years ago

Again and again... :apple: Build Status

This time qt is linked so qmake is on PATH

nuclearsandwich commented 5 years ago

The CI failures above are caused by a rash of infrastructure related troubles and a recent issue with Windows that is not introduced by this change.

Build on our current MacOS configuration is passing: Build Status The updated MacOS configuration where this issue was first discovered is now able to build packages dependent on TinyXML2 but has issues with other upgraded packages Build Status Windows test failures are unrelated Build Status (also failures are causing builds to run very long)

I am proposing that given the reviews received on this change and the CI coverage as available, that this PR be considered merge-able.