search

ros2 / tinyxml2_vendor

temporary vendor package for tinyxml2
Apache License 2.0
2 stars 9 forks source link

Fix bug in FindTinyXML2 for optimized builds #9

Closed j-rivero closed 4 years ago

j-rivero commented 4 years ago

Trivial fix. Probably killing the packaging_windows job.

Karsten1987 commented 4 years ago

can you trigger a windows build job with RelWithDebInfo? To verify that this is indeed the fix?

j-rivero commented 4 years ago

This seems not be enough to fix the problem Build Status

Karsten1987 commented 4 years ago

There seems to be something fundamentally wrong while exporting/importing dependencies and their targets. The chain of dependencies here:

tinyxml2_vendor -> TinyXML2 -> pluginlib -> rosbag2_cpp -> rosbag2_transport

From what I can see in the code all packages along this line are exporting the dependencies correctly. I have no idea why rosbag2_transport wouldn't find tinyxml2::tinyxml2, needless to say I don't understand why it would work on regular CI in the first place.