search

ros2 / tinyxml_vendor

Vendor package for providing tinyxml within a cmake package
Apache License 2.0
2 stars 14 forks source link

Use PATHS keyword in find_* methods. #1

Closed nuclearsandwich closed 7 years ago

nuclearsandwich commented 7 years ago

According to the docs for find_path and find_library suggested paths need to be behind the PATHS keyword.

This will help get us closer to debugging Windows builds.

cc @Karsten1987 since we've been working on this.

nuclearsandwich commented 7 years ago

I'm still not certain whether FindTinyXML.cmake is supposed to be invoked when a cmake package config file is found.

Karsten1987 commented 7 years ago

Does that PATH variable point to the system registry under windows?

nuclearsandwich commented 7 years ago

Does that PATH variable point to the system registry under windows?

It uses CMake variables that are defined in the CMake package configuration file in %ChocolateyInstall%\lib\tinyxml-usestl\share\cmake Which is a directory CMake looks in because the system registry tells it to look their for TinyXML.

I screened this using your eigen_test workspace and running the generator with the package installed normally and verifying the libraries and includes are found, then by changing the key name in the system package registry away from TinyXML and regenerating the build. This latter time failed, which gives me hope that updating these will make the generator work.

nuclearsandwich commented 7 years ago

@Karsten1987 I think we need this before that build will succeed.

nuclearsandwich commented 7 years ago

I'm not convinced this change is bad but it also isn't necessary so I'm closing this for now.