search

ros2 / tinyxml_vendor

Vendor package for providing tinyxml within a cmake package
Apache License 2.0
2 stars 14 forks source link

Pass -Wno-dev to external package CMake invocation #23

Closed cottsay closed 3 years ago

cottsay commented 3 years ago

This will prevent CMake warnings generated by tinyxml's CMakeLists.txt which are intended for the tinyxml developers from popping up in our CI builds. This pattern is already in use in 8 other vendor packages in ROS 2.

Before:

After:

cottsay commented 3 years ago

Ooh, actually it looks like we maintain the CMakeLists.txt for this project in this repository, so we actually want to see those warnings!