search

ros2 / tinyxml_vendor

Vendor package for providing tinyxml within a cmake package
Apache License 2.0
2 stars 14 forks source link

Try to find Config package in TinyXML Module file. (Take 2) #4

Closed nuclearsandwich closed 7 years ago

nuclearsandwich commented 7 years ago

This is an in-fork retarget of https://github.com/ros2/tinyxml_vendor/pull/3 Original PR body below:

This PR alters the TinyXML module file to first look for a package in CMake's package registry [1] in order to allow externally installed tinyxml packages which provide their own CMake configuration to be considered by our finder module since CMake will not look in its own package registry if a find module for the package is found.

This change will break builds using tinyxml_vendor on systems where the CMake package registry includes an invalid tinyxml installation which was previously being ignored. However, I don't think that this should stop the PR since the required resolution would only be to remove or repair the TinyXML CMake package.

@Karsten1987 I'd suggest doing a few more manual builds targeting this branch of tinyxml_vendor.

Will this PR be automatically picked up by any of the other CI jobs? If not, I'd like to figure out which of the Linux and Mac OS jobs would be the best to test this for regressions?

This supercedes #1 as a solution to the Windows build difficulties, but I'm still not clear on whether the changes proposed in #1 are necessary for the find module to behave correctly. This should resolve #2 by explicitly looking for a configured package in the find module before trying to manually find the package.

Karsten1987 commented 7 years ago

windows Build Status linux: Build Status merging this branch.