search

ros2 / tutorials

Apache License 2.0
30 stars 11 forks source link

use std chromo literals #13

Closed wjwwood closed 7 years ago

wjwwood commented 7 years ago

Connects to ros2/rclcpp#282

dirk-thomas commented 7 years ago

This results in a new compiler warning: http://ci.ros2.org/view/nightly/job/nightly_linux_debug/301/warnings22Result/new/

codebot commented 7 years ago

Oh I remember this from a different spot. It's a new thing in c++14 where if you override the unsized version of delete, you need to also override the sized version of delete. The easiest thing is to just have that call through to the unsized version of delete. I think I did this in the real-time test somewhere to get rid of a warning. On phone now but will try to find it later tonight.

On Dec 17, 2016 3:32 PM, "Dirk Thomas" notifications@github.com wrote:

This results in a new compiler warning: http://ci.ros2.org/view/ nightly/job/nightly_linux_debug/301/warnings22Result/new/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ros2/tutorials/pull/13#issuecomment-267793843, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBR2puL-pvYp6zPWZFv-_UHoe4QguUKks5rJHD1gaJpZM4LP1CD .

codebot commented 7 years ago

Here is what I did to fix this warning in realtime_support: https://github.com/ros2/realtime_support/pull/50/commits/ea5dd3dae74bf7ac893ed75e19c590a9e42d97cd

wjwwood commented 7 years ago

Sorry, I fixed this when I migrated it to demos:

https://github.com/ros2/demos/commit/d4558fec5eb62b1d101430c4eebaa4b5b082d31c

I forgot to fix it in tutorials because I was excluding tutorials for my beta 1 testing.

On Sat, Dec 17, 2016 at 6:36 PM Morgan Quigley notifications@github.com wrote:

Here is what I did to fix this warning in realtime_support:

ros2/realtime_support@ea5dd3d https://github.com/ros2/realtime_support/pull/50/commits/ea5dd3dae74bf7ac893ed75e19c590a9e42d97cd

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ros2/tutorials/pull/13#issuecomment-267799744, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGIS1MQGAWzFuBcIVNNwURilEWK2YdCks5rJJwRgaJpZM4LP1CD .

wjwwood commented 7 years ago

I opened https://github.com/ros2/tutorials/pull/14, which I am fairly confident will address the issue since it is exactly the same patch as I used on the version of this code which I moved to the demos repository.

Also this repository is currently commented out in the ros2.repos file.