search

ros2 / tutorials

Apache License 2.0
30 stars 11 forks source link

rclcpp::node::Node is wrong and can not build #21

Closed lxbeyond closed 6 years ago

lxbeyond commented 6 years ago

change "rclcpp::node::Node " to "rclcpp::Node", and then it works

mikaelarguedas commented 6 years ago

thanks @lxbeyond for reporting this. The node namespace has been removed (https://github.com/ros2/rclcpp/pull/416) so rclcpp::node::Node is now rclcpp::Node. It looks like this repository has not been updated when the changed was propagated

mikaelarguedas commented 6 years ago

As a side note, this repository is currently note used (neither compiled nor tested) in ROS2 and we encourage users to refer to the examples and demos repositories as pointed out in the README

dhood commented 6 years ago

there are some more instances of this (e.g. rclcpp::parameter_service::ParameterService) that I'll fix up

Karsten1987 commented 6 years ago

it might be worth discussing whether we should close this repo in favor of the example or demo packages.

mikaelarguedas commented 6 years ago

@dhood if it helps I started fixing all namespace issues on https://github.com/ros2/tutorials/tree/tutorials_compiling when this issue was reported. I didnt follow up as I agree with @Karsten1987 and don't think we should maintain 2 versions of the same code as long as we advise user to discard this repository so I'd like to bring this up in aROS2 meeting before we spend time on it

dhood commented 6 years ago

I'll merge this as is then and not spend additional time on it until we know it makes sense