Closed dhood closed 7 years ago
I feel like using composition is making the service and parameter examples quite a bit harder to follow. (pub-sub's not too bad)
Does anyone have an opinion on if this is worthwhile for tutorials? We might be better off sacrificing best practices for readability when we are presenting these topics for the first time.
Just to recap here, I think @dhood is going to migrate her comments/documentation to the composition demo: https://github.com/ros2/demos/blob/master/composition/src/listener_component.cpp and https://github.com/ros2/demos/blob/master/composition/src/talker_component.cpp
And @Karsten1987 is going to add service and client examples in the composition demos repository.
And then we're going to drop this repository from the repos file for beta 1 since we're not ready to make complete tutorials yet.
Is that how everyone else understood it?
Thanks for the summary. That matches my recollection and notes.
On Fri, Dec 16, 2016 at 2:44 PM, William Woodall notifications@github.com wrote:
Just to recap here, I think @dhood https://github.com/dhood is going to migrate her comments/documentation to the composition demo: https://github.com/ros2/demos/blob/master/composition/src/ listener_component.cpp and https://github.com/ros2/demos/ blob/master/composition/src/talker_component.cpp
And @Karsten1987 https://github.com/Karsten1987 is going to add service and client examples in the composition demos repository.
And then we're going to drop this repository from the repos file for beta 1 since we're not ready to make complete tutorials yet.
Is that how everyone else understood it?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ros2/tutorials/pull/9#issuecomment-267714267, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBR2s9dqi2uKajFGSkjEeGX0ygidy0wks5rIxRbgaJpZM4LPTIn .
closing in favour of https://github.com/ros2/demos/pull/97 and https://github.com/ros2/demos/pull/95
WIP - working on services and parameters