search

ros2 / urdf

Repository for URDF parsing code
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

urdf doesnt depend on console_bridge ATM #4

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

connects to ros2/console_bridge_vendor#1

sloretz commented 6 years ago

It looks like there is commented code using logging macros. Is the plan to delete those blocks too?

https://github.com/ros2/urdf/blob/b9386db8898a64dc2aa6a2ed08a83d3b470ff918/urdf/src/model.cpp#L88-L94

mikaelarguedas commented 6 years ago

These macros are not provided by console_bridge, they come from rosconsole_bridge.

I would expect these block to be modified to use ROS 2 logging if / when they get reenabled and not ROS 1 logging