Fix goal state - Githubissues

ros2dart / dartros1

A ROS1 client library for dart

Apache License 2.0

20 stars 11 forks source link

Fix goal state #23

Closed knuesel closed 3 years ago

knuesel commented 3 years ago

Hi, this adds an export necessary for the argument types of the callbacks passed to sendSimpleGoal.

This also changes the "done" callback to report a SimpleClientGoalState instead of a SimpleGoalState (the latter can only be PENDING/ACTIVE/DONE so gives no way of detecting errors).

(The new behavior matches the Python, C++ and rosnodejs implementations.)

knuesel commented 3 years ago

Thanks for the quick merge 😊 Would it be OK to have a release with this fix? (I'm using it in a small app I want to distribute).

TimWhiting commented 3 years ago

Yeah, no problem. Just updating the CHANGELOG now Update: Published!

knuesel commented 3 years ago

Awesome, thanks!