Feature/emp annot auth

[nickcrawford1]

I'm going to make a new comment for each issue encountered while testing out this new version. If you respond to each then we can keep a thread of what's going on.

[nickcrawford1]

1 - The depositor account can only save a workflow and does not appear to have any way to submit it.

[nickcrawford1]

2 - There dosen't seem to be a way to log out of the application for us to try out the annotator account... Is this because the annotator side is specific to you and your system so not something for us to worry about?

[nickcrawford1]

3 - The bug where it duplicates the entries at the review stage is fixed within the template section, however if you go to a saved entry and use the 'edit' func, this then duplicates the entries when you reach the review section.

I suspect it will require the same fix but just in another location.

[sriram-ebi]

1 - The depositor account can only save a workflow and does not appear to have any way to submit it.

Depositors can not submit an entry initially if it's created from a Template entry. The entries created from a template go to the Saved list as a draft at first and it can picked up from the Saved list to make further edits to submit it for annotation

[sriram-ebi]

2 - There dosen't seem to be a way to log out of the application for us to try out the annotator account... Is this because the annotator side is specific to you and your system so not something for us to worry about?

Since we do not have actual authentication the LOCCURRENTUSER under config.json has to be set to 'depositor' or 'annotator' to render the respective view.

[sriram-ebi]

3 - The bug where it duplicates the entries at the review stage is fixed within the template section, however if you go to a saved entry and use the 'edit' func, this then duplicates the entries when you reach the review section.

I suspect it will require the same fix but just in another location.

I am checking this right away, once I have the fix I shall push it to the feature branch within tomorrow

[nickcrawford1]

1 - The depositor account can only save a workflow and does not appear to have any way to submit it.

Depositors can not submit an entry initially if it's created from a Template entry. The entries created from a template go to the Saved list as a draft at first and it can picked up from the Saved list to make further edits to submit it for annotation

Ok in which case, that mechanism didn't seem to work in the version running. When I went to the draft in 'saved' my only option was to view or edit.

• Edit just went through the template stuff again (created the duplication highlighted in issue 3) and then allowed me to update the draft.
• View the only options were to download the json or image

[sriram-ebi]

3 - The bug where it duplicates the entries at the review stage is fixed within the template section, however if you go to a saved entry and use the 'edit' func, this then duplicates the entries when you reach the review section. I suspect it will require the same fix but just in another location.

I am checking this right away, once I have the fix I shall push it to the feature branch within tomorrow

The issue is now fixed in the commit 73d2b5b

[nickcrawford1]

@sriram-ebi

The most recent commit appears to have introduced a new action where each time one of the menu options is clicked from the home page, it deploys the result in a new tab. Is this an intentional behavior or is this a bug?

This 'open in new tab' action doesn't occur when clicking the tiles in the center of the home page. just the menu on the left.

If we can get this sorted, I should be able to get the rest of the merge done today :)

[sriram-ebi]

@sriram-ebi

The most recent commit appears to have introduced a new action where each time one of the menu options is clicked from the home page, it deploys the result in a new tab. Is this an intentional behavior or is this a bug?

This 'open in new tab' action doesn't occur when clicking the tiles in the center of the home page. just the menu on the left.

If we can get this sorted, I should be able to get the rest of the merge done today :)

I’ve adjusted the menu click to open in a new tab to prevent the workflow data from being repeated. The issue with repetitive workflow data happens when an ongoing workflow edit is interrupted by opening a new edit. We’re now opening edits (and other menus) in a separate tab to avoid this inconsistency.

I shall also make the same correction for the tile and update the commit number of the fix soon.

[sriram-ebi]

@sriram-ebi The most recent commit appears to have introduced a new action where each time one of the menu options is clicked from the home page, it deploys the result in a new tab. Is this an intentional behavior or is this a bug? This 'open in new tab' action doesn't occur when clicking the tiles in the center of the home page. just the menu on the left. If we can get this sorted, I should be able to get the rest of the merge done today :)

I’ve adjusted the menu click to open in a new tab to prevent the workflow data from being repeated. The issue with repetitive workflow data happens when an ongoing workflow edit is interrupted by opening a new edit. We’re now opening edits (and other menus) in a separate tab to avoid this inconsistency.

I shall also make the same correction for the tile and update the commit number of the fix soon.

Tile redirects are fixed in the commit 59fedce

[nickcrawford1]

redirects are

That hasn't fixed the issue. The menu on the left still opens each one in a new tab but now the tiles in the center area open a completely new browser window..

[nickcrawford1]

@sriram-ebi The most recent commit appears to have introduced a new action where each time one of the menu options is clicked from the home page, it deploys the result in a new tab. Is this an intentional behavior or is this a bug? This 'open in new tab' action doesn't occur when clicking the tiles in the center of the home page. just the menu on the left. If we can get this sorted, I should be able to get the rest of the merge done today :)

I’ve adjusted the menu click to open in a new tab to prevent the workflow data from being repeated. The issue with repetitive workflow data happens when an ongoing workflow edit is interrupted by opening a new edit. We’re now opening edits (and other menus) in a separate tab to avoid this inconsistency.

I shall also make the same correction for the tile and update the commit number of the fix soon.

I'll open a discussion with Michelle this side but this to me seems like an bad way to have the site work. In just clicking to check different sections, you end up with multiple tabs/sessions open which quickly clutteres the browser which will become a nightmare for users who are likely to already have multiple browser tabs open.

I guess for now if you can correct the tiles so they open the tab in the same window rather than another browser, I'll bring the issue to Michelle to discuss user requirements and usability.