rosalindfranklininstitute / parakeet

Phantom generator
GNU General Public License v3.0
18 stars 5 forks source link

[WIP] Proposed scan interface #9

Closed alisterburt closed 3 years ago

alisterburt commented 3 years ago

Here is a proposal for a new Scan interface, submitting for feedback before trying to refactor existing Scan objects and interface these objects with the simulation code.

Previously, Scan objects could scan rotations around a single axis and optionally shift the sample between exposures during the scan.

With the proposed interface, an arbitrary set of poses can be simulated. The poses, comprising orientations and shifts, are defined in a new PoseSet object.

This implementation adds a scipy dependency, if you feel strongly about this, we could extract and reimplement the features used here.

alisterburt commented 3 years ago

@jmp1985 cheers! Changes sound good to me - if you want to zoom to hash out coordinate systems this morning just drop me a message :)