search

rosalogia / rucs24-bot

A discord bot for the Rutgers Class of 2024 Computer Science server
MIT License
6 stars 11 forks source link

[BUG] Undesirable project file structure noise due to API Cog #66

Open rosalogia opened 4 years ago

rosalogia commented 4 years ago

Describe the bug There are a few issues in the project structure related to the API cog, or more accurately the RU course sniper cog. It is not very self contained, although it can and should be. Furthermore, it should be named something more reflective of its functionality. I am leaving this to @Likey00 since it is his cog and he knows the design best.

Likey00 commented 4 years ago

could you be more specific pls

rosalogia commented 4 years ago

For the most part, I just want the pyscripts and apidata folders to not take up space in the project root. if you want you can move pyscripts to the cogs folder and import them locally from the api cog. You can also feel free to make a sub-folder in data/ to store api data. And, if this wasn't clear in the issue itself, the apicog and apidata folders should be named more accurately, e.g. coursesnipercog.py and course_sniper_data. It's up to you what you call them, but this is a little confusing for those who weren't here when it was being developed.