NC25 compatibility

[SteelPC]

Can you please add compatibility with NC25 ? Thank you :heart:

[p-bo]

Just in case it wasn't noticed - Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo

[xklonx]

Nice, but the problem is i didnt find any example of what to do with scss files as they not supported anymore.

[p-bo]

Maybe what about to ask on https://help.nextcloud.com/c/dev/11 to unstuck?

Or on chat with developers https://cloud.nextcloud.com/call/xs25tz5y (found on https://nextcloud.com/developer/ )

Or in general, this thread could help eventually: https://help.nextcloud.com/t/boosting-community-app-development/142442.

Last resort could be to look on contacts at people from Engineering team: https://nextcloud.com/team/ (scroll down)

[p-bo]

problem is i didnt find any example of what to do with scss files as they not supported anymore.

Maybe in this app they are solving the same issue? https://github.com/mwalbeck/nextcloud-breeze-dark/issues/317#issuecomment-1333892300

[unixtom]

Office Online Server dont have Fullscreen. Fixed the Problem top ADD style="width: -webkit-fill-available; height: -webkit-fill-available;" to
<iframe id=""wopiframe" in viewer.js

[SteelPC]

Hello, any news on the update ?

[p-bo]

i didnt find any example of what to do with scss files as they not supported anymore.

Maybe there was the same problem https://github.com/danielroehrig/diary/issues/54#issuecomment-1397874023

And solution could inspire there https://github.com/danielroehrig/diary/pull/55/commits

?

[small1]

Simple fix. Make viewer.css (that the code is looking for but gets a 404. Change the css and add

#wopiframe {
width: -webkit-fill-available;
height: -webkit-fill-available;
}

There is much nicer solutions .. but this one is simple to get started. After my initial testing it seems to be the only problem right now.

[xklonx]

https://github.com/nextcloud/richdocuments/commit/e332c5413e82d29dbd7cda0267171cb63a1e62e7 Also they removed support of Application.php i somehow fixed that, updated some client libraries, currently have problems with building client side code. I dont have time for that currently.

[small1]

I will see if i can make some fixes to make it usable on 25 early next week

[SteelPC]

Any news on NC25 compatibility ?

[SteelPC]

Anyone working on this ? I need to upgrade to NC25 this summer, I'll be sad to drop this great app :(

[small1]

NC now has their own app for this

[SteelPC]

I missed that I guess. Anyone documentation on it ?

Le jeu. 15 juin 2023, 12:16, Johan Bernhardsson @.***> a écrit :

NC now has their own app for this

— Reply to this email directly, view it on GitHub https://github.com/roscomputing/richdocuments/issues/374#issuecomment-1592765698, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARA7NX2UNFNA6QWIMFOEEMDXLLOG7ANCNFSM6AAAAAASAZGUAQ . You are receiving this because you authored the thread.Message ID: @.***>

[small1]

https://apps.nextcloud.com/apps/officeonline

[SteelPC]

Thank you :) I'll test it out