rose-compiler / rose

Developed at Lawrence Livermore National Laboratory (LLNL), ROSE is an open source compiler infrastructure to build source-to-source program transformation and analysis tools for large-scale C (C89 and C98), C++ (C++98 and C++11), UPC, Fortran (77/95/2003), OpenMP, Java, Python and PHP applications.
http://rosecompiler.org
Other
606 stars 131 forks source link

New prerequisite for C++ 14 #192

Closed sei-mwd closed 1 year ago

sei-mwd commented 2 years ago

Commit 6d7655bce862d50aeb177265d89549caa6ce10a0 starts using C++ features that require C++ 14 compliance. (Templated variables, std::conditional_t, etc.) I have no objection to that, but the build systems need to be updated to require C++ 14 as a minimum for building.

matzke1 commented 2 years ago

ROSE now checks that a C++14 compiler is being used and if not, fails early with the error message "ROSE requires a C++14 or later compiler" rather than complaining later about some unsupported C++14 feature being used. The error comes from <rose/featureTests.h>, which is included by nearly every ROSE source file and included indirectly by in most user code that uses the ROSE library. However, since the Microsoft Visual C++ Compiler erroneously advertises itself as a C++98 compiler, this early check is not performed there.

If there are other places, such as documentation, that still mention C++11 as a requirement, please let us know so we can also fix them. Thanks.

md5i commented 2 years ago

Pull request #194 adds CMake support for requiring a C++ 14 compiler.

sei-mwd commented 2 years ago

Thanks. I added a pull request that updates CMakeLists.txt to require C++ 14 support.


From: Michael Welsh Duggan @.***> Sent: Friday, April 29, 2022 11:40 AM To: rose-compiler/rose Cc: Michael Welsh Duggan; Author Subject: Re: [rose-compiler/rose] New prerequisite for C++ 14 (Issue #192)

Pull request #194https://github.com/rose-compiler/rose/pull/194 adds CMake support for requiring a C++ 14 compiler.

— Reply to this email directly, view it on GitHubhttps://github.com/rose-compiler/rose/issues/192#issuecomment-1113460060, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHC4PIQH6XNECUS6GF7JBELVHP7GVANCNFSM5UPX6DOQ. You are receiving this because you authored the thread.Message ID: @.***>

matzke1 commented 1 year ago

Merged.