rose-pine / gtk

Soho vibes for GTK
220 stars 4 forks source link

Add libadwaita theme and fix legacy theming #10

Closed ashbork closed 2 years ago

ashbork commented 2 years ago

Following the release of libadwaita and its adoption in GNOME 42 this theme no longer works as expected on updated GNOME instances.

GTK 4

Theming within GTK 4 seems to be easier than ever with a single css file allowing for pretty extensive modifiactions of pretty much every part of the toolkit. A new set of themes could be released (I'm already working on one, though I'm not sure whether to base it on this repository or create a new one for gtk4).

Regarding the legacy theme

As of now, the gtk-3 theme can still be used with GNOME Tweaks (as shown below). image However, if you're using GNOME in dark mode (which you probably are if you're using a dark them. e such as RP or RPM) the background colors are flipped. Example: image The workarounds for this issue could be either of these:

Both of these aren't ideal and will be annoying for users to install and understand, but the latter seems doable.

mvllow commented 2 years ago

I think ideally we would have a gtk3 folder and gtk4 within this repo (or only gtk3 and have the root be the latest version?). If you want to tackle this that would be lovely and much appreciated 😌

ashbork commented 2 years ago

I'll certainly see what I can do!

ThatOneCalculator commented 2 years ago

Sadly I have literally no clue how gtk4 themes are made lol